Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add JSON response to GET Audit Template submission #4477

Merged
merged 4 commits into from
Jan 16, 2024
Merged

Add JSON response to GET Audit Template submission #4477

merged 4 commits into from
Jan 16, 2024

Conversation

kflemin
Copy link
Contributor

@kflemin kflemin commented Jan 10, 2024

This is to support 179D and used by py-seed.

Add 'JSON' response type to audit template submission GET. This returns metadata on the submission, such as tax_id (179d_id) so that it can be properly linked back to the 179d project in the portal.

@kflemin kflemin added the Enhancement Add this label if functionality was generally improved but not a full feature or maintentance. label Jan 10, 2024
@kflemin kflemin requested a review from nllong January 10, 2024 22:34
@nllong nllong changed the title add JSON response support to audit template submission GET Add JSON response support to audit template submission GET Jan 15, 2024
@nllong nllong changed the title Add JSON response support to audit template submission GET Add JSON response to GET Audit Template submission Jan 15, 2024
Copy link
Member

@nllong nllong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good, amazing!

@nllong
Copy link
Member

nllong commented Jan 16, 2024

#4485 will fix the docs building CI test issue...

@nllong nllong merged commit 418e9c0 into develop Jan 16, 2024
8 checks passed
@nllong nllong deleted the at-json branch January 16, 2024 22:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Enhancement Add this label if functionality was generally improved but not a full feature or maintentance.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants