-
Notifications
You must be signed in to change notification settings - Fork 55
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support unicode characters by replacing unidecode with new normalize method #4484
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Label error. Requires at least 1 of: Feature, Bug, Enhancement, Maintenance, Documentation, Performance, Do not publish. Found: |
nllong
added
the
Feature
Add this label to new features. This will be reflected in the change log when generated.
label
Jan 15, 2024
nllong
changed the title
Replace unidecode with new normalize method
Support unicode characters by replacing unidecode with new normalize method
Jan 15, 2024
nllong
force-pushed
the
enable-unicode-in-fields
branch
from
January 18, 2024 01:10
642d4d5
to
6e0b296
Compare
nllong
commented
Jan 18, 2024
axelstudios
approved these changes
Jan 22, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Feature
Add this label to new features. This will be reflected in the change log when generated.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Any background context you want to provide?
Back in 2016 we addd the unidecode library to fix unicode issues with the data. That worked well until now, where we need to keep diacritics/accent marks and further support the arabic character set.
What's this PR do?
How should this be manually tested?
What are the relevant tickets?
#4479
Screenshots (if appropriate)