Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix program setup's new program button action #4499

Merged
merged 14 commits into from
Feb 5, 2024

Conversation

perryr16
Copy link
Contributor

@perryr16 perryr16 commented Jan 23, 2024

Any background context you want to provide?

The "New Program" button on the program insights config page would save invalid programs to the db on each click.

What's this PR do?

New programs are only created when they have passed validation via the 'Save Changes' button

How should this be manually tested?

Go to Program Insights config modal and click "New Program" multiple times. Nothing should happen after the first click.

What are the relevant tickets?

#4321

Screenshots (if appropriate)

@perryr16 perryr16 added the Bug label Jan 23, 2024
@perryr16 perryr16 marked this pull request as ready for review January 31, 2024 20:07
@perryr16 perryr16 requested a review from kflemin January 31, 2024 20:07
Copy link
Contributor

@kflemin kflemin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

works great...thanks for fixing!

@kflemin kflemin merged commit d074aa3 into develop Feb 5, 2024
8 checks passed
@kflemin kflemin deleted the 4321-program-setup-new-program-btn-action branch February 5, 2024 17:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants