Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow data logger deletion #4563

Merged
merged 7 commits into from
Mar 18, 2024
Merged

Allow data logger deletion #4563

merged 7 commits into from
Mar 18, 2024

Conversation

haneslinger
Copy link
Contributor

Copy link

Label error. Requires at least 1 of: Feature, Bug, Enhancement, Maintenance, Documentation, Performance, Do not publish. Found:

@haneslinger haneslinger added the Feature Add this label to new features. This will be reflected in the change log when generated. label Mar 11, 2024
Copy link
Contributor

@perryr16 perryr16 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works great. One suggestion (but feel free to ignore 🙂), reuse one of the existing delete buttons for continuity (ex: see inv detail notes delete)

@perryr16
Copy link
Contributor

maybe switch the button colors? delete - red, dismiss - gray?

@kflemin kflemin mentioned this pull request Mar 18, 2024
@haneslinger haneslinger merged commit bbe521f into develop Mar 18, 2024
8 checks passed
@haneslinger haneslinger deleted the Allow-data-logger-deleteion branch March 18, 2024 23:07
@axelstudios axelstudios changed the title Allow data logger deleteion Allow data logger deletion Mar 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Feature Add this label to new features. This will be reflected in the change log when generated.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants