Clear invalid label tags #4591
Merged
Clear invalid label tags #4591
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Any background context you want to provide?
The label filters (and, or, exclude) are based attached to the model via a
<tags-input>and<auto-complete>elements. If a valid label is selected, its value is attached to the<tags-input>'s ng-model. If invalid text is entered, it is not attached to the ng-model and not available to reset in $scope. This makes clearing the text difficult.What's this PR do?
After resetting the ng-model's labels, the trashcan icon will also re-render the
<tags-input>element, clearing any remaining text.It's a little hacky, but it's cleaner than trying to locate the correct HTML element within , clear its contents, and convince the element that it is now in a 'valid' state.
How should this be manually tested?
Add a few labels. Filter on those labels. Add some random text to the filter fields. Hit the trash icon.
What are the relevant tickets?
#4305
Screenshots (if appropriate)
Screen.Recording.2024-03-27.at.10.37.18.AM.mov