-
Notifications
You must be signed in to change notification settings - Fork 55
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Ruff linting and formatting #4604
Conversation
# Conflicts: # seed/data_importer/match.py # seed/utils/inventory_filter.py
# Conflicts: # seed/tests/test_audit_template.py
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks good. Ruff is so much faster than autopep--so nice.
I fixed a couple more typos and formatted the local_untracked.py.dist
file.
attrs={'class': 'field', 'placeholder': 'Password'}) | ||
self.fields['password2'].widget = forms.PasswordInput( | ||
attrs={'class': 'field', 'placeholder': 'Confirm Password'}) | ||
super().__init__(*args, **kwargs) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
wow, old python 2.7 relic
@@ -41,7 +37,7 @@ | |||
TaxLotAuditLog, | |||
TaxLotProperty, | |||
TaxLotState, | |||
TaxLotView | |||
TaxLotView, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yes, I love this setting... being serious.
name='create', | ||
decorator=[has_perm_class('requires_owner')] | ||
) | ||
@method_decorator(name="list", decorator=[has_perm_class("requires_owner")]) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
cleaner, nice
|
||
setattr(property_measure, key, value) | ||
updated_value = value | ||
if key in self.enum_validators: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
much better way to iterate over keys
What's this PR do?
tox -e precommit -- ruff
tox -e precommit -- ruff-format
docker-compose
calls withdocker compose
/src/*
from MyPy testingnpm-shrinkwrap.json
referencesHow should this be manually tested?
The CI should pass