Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix mapping previews for files with a single column #4611

Merged
merged 2 commits into from
Apr 11, 2024

Conversation

axelstudios
Copy link
Member

Any background context you want to provide?

We've had a bug for a long time that prevented seeing the first five rows during mapping of a file with a single column of data

What's this PR do?

Fixes the five-row preview when mapping a file with a single column of data

How should this be manually tested?

  1. Create a file with a single column of data, e.g.:
    Custom ID 1
    120243 E True Lane
    95373 E Peach Avenue
    95864 SW Cottonwood Court
    155371 W Cherry Loop
    180821 S Tyler Lane
    
  2. Upload the file and go to the mapping page
  3. The first-five-rows preview should show the full values, not just the first letter of each

Screenshots (if appropriate)

Before and after:

Single-Column-Import

Copy link
Contributor

@kflemin kflemin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@axelstudios axelstudios merged commit 7504930 into develop Apr 11, 2024
9 checks passed
@axelstudios axelstudios deleted the bugfix/fix-single-column-file-mapping branch April 11, 2024 23:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Status: Ready to Deploy
Development

Successfully merging this pull request may close these issues.

None yet

2 participants