Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix ubid bugs #4613

Merged
merged 6 commits into from
Apr 9, 2024
Merged

Fix ubid bugs #4613

merged 6 commits into from
Apr 9, 2024

Conversation

perryr16
Copy link
Contributor

@perryr16 perryr16 commented Apr 5, 2024

Any background context you want to provide?

This is in response to some bugs Robin encountered while testing the UBID work

What's this PR do?

  • Fixes a bug that caused the import process to hang if ubid was the only matching criteria
  • Fixes a bug that did not preserve access level instances on merges

How should this be manually tested?

The following test files include the NREL FTLB, the NREL Cafe, and an invalid property without a ubid. Each file increases the ubid footprint.

  1. set matching criteria to only ubid
  2. upload a file with ubids 3props_ubids_0.xlsx
  3. in org settings change the ubid threshold to 0.1 to allow matching
  4. upload a file with slightly different ubids 3props_ubids_1.xlsx
  5. properties should have been merged and preferred ubid set to the incoming ubid (see inventory detail ubid)
  6. change the org setting ubid threshold to something more strict, like 0.9
  7. upload a file with slightly different ubids 3props_ubids_4.xlsx
  8. new views have been created as incoming properties did not meet matching criteria
  9. change the org setting ubid_threshold back to 0.1
  10. upload a file with slightly different ubids 3props_ubids_5.xlsx
  11. all properties with overlapping ubids should have been merged and ubid history preserved
  12. unmerge a merged property, check ubid history for each property

What are the relevant tickets?

Screenshots (if appropriate)

@perryr16 perryr16 added the Bug label Apr 5, 2024
@perryr16 perryr16 marked this pull request as ready for review April 9, 2024 15:54
@perryr16 perryr16 requested a review from kflemin April 9, 2024 15:55
Copy link
Contributor

@kflemin kflemin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉

@kflemin kflemin merged commit e232cc5 into develop Apr 9, 2024
9 checks passed
@kflemin kflemin deleted the 3957-bug-ubid-import-hangs branch April 9, 2024 20:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Status: Ready to Deploy
Development

Successfully merging this pull request may close these issues.

None yet

2 participants