Fixes bug to hide edit form on save #4623
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
perryr16
commented
Apr 10, 2024
| @@ -475,7 +476,7 @@ angular.module('BE.seed.controller.inventory_detail', []).controller('inventory_ | |||
| * save_item: saves the user's changes to the Property/TaxLot State object. | |||
| */ | |||
| const save_item_resolve = (data) => { | |||
| $scope.$emit('finished_saving'); | |||
There was a problem hiding this comment.
This emit statement looks like it was related to hiding the form, but I went back several years and couldnt find any reference to 'finished_saving' outside of these two $emits
Honestly, I'm not sure how this worked before.
perryr16
force-pushed
the
bug-inv-det-save-form
branch
from
dd6635a
to
070b047
Compare
kflemin
approved these changes
Apr 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Any background context you want to provide?
From the inventory detail, after saving inventory edits the from remained in edit mode. I went back to PRs from 2023 and experienced the same behavior
What's this PR do?
How should this be manually tested?
What are the relevant tickets?
Screenshots (if appropriate)