-
Notifications
You must be signed in to change notification settings - Fork 16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Movement issue39: adjust code to incorporate new flux model objects #58
Movement issue39: adjust code to incorporate new flux model objects #58
Conversation
…ls. This change is not complete as the continuum.flux() function requires further adjustment based on the flux.model selected
…jects. The code is now running but not yet sure if the results are equivalent. Require further testing
…ng the returned optimresult be not consistent with the results before the refactoring
…del() function which caused a warning
…ill fix the errors caused by Travis CI
… generic 'object' which could fail the build again
Hmm, I suspect a better approach (since it will also make the code more readable and therefore easier for me to check the code matches up with the docs) would be to split up the function It would also be handy to record the name of flux approach in the fl <- intervening.opportunities()
fl$name
|
…lure of the travis checks
Current coverage is
|
… following the agreed naming convention
…rediction methods'
…functions corresponding to the flux models used in the package. Adjusted the tests and docs accordingly
… flux models to be more specific for the model used. Also, adjusted the examples for each of the variants.
@goldingn :once the checks for travis-ci are completed for my last commit, I would be happy will all changes addressing this pull request. In my last commits I addressed all the outstanding issues I mentioned above and I made the change to the continuum.flux function as you suggested. Please have a look and let me know if you are happy for me to merge this (bigger) change. Thanks. |
Looks great to me! |
…-models Movement issue39: adjust code to incorporate new flux model objects
@goldingn : This change is not completed done yet, but still would like you to have a look as this is a bigger change.
Outstanding issues are