Feature/robot random tests #2866
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Prior to this fix the test would randomly fail when this suite was run in random order. With this fix it passes every time. I'm not sure why the code was changed to check for failure_occurred rather than capture_page_screenshot, especially since I wanted to explictly check for capture_page_screenshot.
prescod
previously approved these changes
Sep 13, 2021
prescod
approved these changes
Sep 13, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This improves the pageobject unit tests. They can now be run in random order without failing.
I also move the tests from cumulusci/core/tests to cumulusci/robotframework/tests
Critical Changes
Changes
Issues Closed