Add better error handling for empty or invalid org and service env vars #3365
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…org or service env vars. Should have 100% test coverage.
|
@jlantz Please look at the linter's suggestions |
added 2 commits
September 19, 2022 19:32
|
@jlantz I believe that this PR has extraneous files in it but I don't want to delete them until I'm confident which version of the files is most up-to-date. |
boakley
previously approved these changes
Sep 26, 2022
davidmreed
approved these changes
Sep 19, 2023
|
Thanks for the contribution! It looks like @prescod is an internal user so signing the CLA is not required. However, we need to confirm this. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Moved from #3341
Thank you @jlantz !
Adds extra error handling and a new exception, ServiceCannotBeLoaded, to match the exception already there for org load issues. Should have 100% test coverage.
Issues Closed