Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Modified service to trim whitespaces #3661

Merged
merged 1 commit into from Sep 21, 2023
Merged

Modified service to trim whitespaces #3661

merged 1 commit into from Sep 21, 2023

Conversation

aditya-balachander
Copy link
Contributor

W-11032451

  • Modified service.py to trim whitespaces from the beginning and end of the value during connect and update.
  • Added tests to verify functionality

@aditya-balachander aditya-balachander requested a review from a team as a code owner September 21, 2023 13:22
davidmreed
davidmreed approved these changes Sep 21, 2023
View reviewed changes
Copy link
Contributor

@davidmreed davidmreed left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work. LGTM.

@davidmreed davidmreed added the enhancement Listed under "Changes" in the changelog label Sep 21, 2023
@davidmreed davidmreed merged commit ac810e5 into main Sep 21, 2023
18 of 19 checks passed
@davidmreed davidmreed deleted the feature/service_trim_whitespaces branch September 21, 2023 15:35
@aditya-balachander aditya-balachander restored the feature/service_trim_whitespaces branch September 21, 2023 16:17
@aditya-balachander aditya-balachander deleted the feature/service_trim_whitespaces branch September 21, 2023 16:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@davidmreed davidmreed davidmreed approved these changes

@kdvenkata kdvenkata Awaiting requested review from kdvenkata

Assignees

@aditya-balachander aditya-balachander

@pratibhavermasalesforce pratibhavermasalesforce

Labels
enhancement Listed under "Changes" in the changelog
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@aditya-balachander @davidmreed @pratibhavermasalesforce