Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

W-15805907: assign_permission_set_licenses accepts the api_names in either developerName or the PermissionSetLicenseKey #3798

Merged
merged 8 commits into from
Jun 14, 2024

Conversation

lakshmi2506
Copy link
Contributor

@lakshmi2506 lakshmi2506 commented Jun 7, 2024

To handle the compatibility issues and ensure smooth functionality for both get_available_permission_set_licenses and assign_permission_set_licenses, you can make the following adjustments:

  1. Revert get_available_permission_set_licenses to Return PermissionSetLicenseKey:

    • This will maintain backward compatibility.
  2. Update assign_permission_set_licenses to Accept Both DeveloperName and PermissionSetLicenseKey:

    • Modify the function to handle input as either DeveloperName or PermissionSetLicenseKey, ensuring it can correctly interpret and process both formats. This adjustment will resolve issues with names like alpha.beta where the DeveloperName is alpha_beta. Accepts api_name as alpha_beta or alpha.beta and assigns them correctly

@lakshmi2506 lakshmi2506 requested a review from a team as a code owner June 7, 2024 07:10
@lakshmi2506
Copy link
Contributor Author

Hi @jkasturi-sf @jstvz @vsbharath

Please review the PR

Thank you

Copy link
Contributor

@jstvz jstvz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Change requested: Please update the task_docs to mention that api_names can contain DeveloperName or PermissionSetLicenseKey. Other comments optional.

cumulusci/tasks/salesforce/users/permsets.py Outdated Show resolved Hide resolved
cumulusci/tasks/salesforce/users/permsets.py Outdated Show resolved Hide resolved
@lakshmi2506
Copy link
Contributor Author

Hi @jstvz

Combined the queries into one, updated the task docs.

Please review the PR
Thank you

@lakshmi2506 lakshmi2506 requested a review from jstvz June 13, 2024 06:03
@jstvz jstvz merged commit 8da8c67 into main Jun 14, 2024
21 of 23 checks passed
@jstvz jstvz deleted the bug/W-15805907_licenses branch June 14, 2024 19:37
@jstvz jstvz added the internal Pull requests from IPDE team label Jun 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
internal Pull requests from IPDE team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants