Label metadeploy steps with package name & version #974
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jstvz
previously approved these changes
Feb 7, 2019
There was a problem hiding this comment.
Two things, neither are blockers:
- Might it make sense to prefix the path in
Deploy sub/dirwith the project name? (or does it do that already?) - It'd be nice to break up
process_github_dependencyinto something more manageable (someday, that is).
Otherwise this is fine.
|
@jstvz for the metadata bundles I'd like to come up with a way to configure a more friendly name, but I'm leaving that for a later pull request. Including the package name in the default does sound good though. |
jlantz
suggested changes
Feb 7, 2019
jlantz
previously approved these changes
Feb 9, 2019
|
@davisagli We need to fix the test failures on Windows before merging. It appears to just be an issue with assertions. |
jlantz
approved these changes
Feb 11, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adjusts how the names for metadeploy steps are determined so that we can show the actual package name and version.
Critical Changes
Changes
Issues Closed