Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add child_count feature #74

Merged
merged 5 commits into from
Jun 12, 2020
Merged

Add child_count feature #74

merged 5 commits into from
Jun 12, 2020

Conversation

prescod
Copy link
Contributor

@prescod prescod commented Jun 11, 2020

Add a feature that allows you to know what your count is within your parent element.

This feature is already documented on master. (the documentation preceded the feature!)

Allows you to know what your count is within your parent element.
@prescod prescod requested a review from davisagli June 11, 2020 23:11
Copy link
Contributor

@davisagli davisagli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this should be called child_index. I stared at it for a few minutes trying to figure out why you were passing the index instead of the total number of children since it's clearly named "count"

@prescod prescod merged commit 55af3c8 into master Jun 12, 2020
@prescod prescod deleted the feature/add-child-count branch June 12, 2020 18:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants