Add sfJoystick tests
#245
Merged
Add sfJoystick tests
#245
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ChrisThrasher
force-pushed
the
test_window
branch
2 times, most recently
from
9921216
to
3204dd3
Compare
|
DLL issues are causing CI to fail. We need to make sure all of the SFML and CSFML DLLs exist in the same directory as the test executables but for some reason that is not the case at the moment. |
ChrisThrasher
force-pushed
the
test_window
branch
4 times, most recently
from
b94b000
to
fddda6f
Compare
ChrisThrasher
force-pushed
the
test_window
branch
from
fddda6f
to
421737b
Compare
These are just copied from the SFML sf::Joystick tests with minor changes to adhere to the CSFML API.
ChrisThrasher
force-pushed
the
test_window
branch
from
421737b
to
1bea7b2
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Most Window module APIs require a display which means pulling in the same
xvfbinfrastructure SFML uses. We can do that eventually, but for now I wrote some quicksfJoysticktests since these don't require a display to be ran in CI.This is yet another instance where having CSFML live inside SFML/SFML would be useful since it could easily pick up the existing infrastructure SFML has like this
xvfbstuff or our clang-format and clang-tidy infrastructure. This is certainly out of scope for SFML 3 but it's still something I'm considering for the future since I think it's both feasible and beneficial.