Skip glTexCoordPointer() call if not needed (performance optimization)

[hobby8]

Aimed at saving memory bandwidth for drawing operations not involving textures nor shaders.
More details in this forum thread.

[eXpl0it3r]

Merged in 973ac8d on master

[naezith]

This update broke one of my shaders, it was working beautifully before. It's broken because my quad does not have a texture so gl_TexCoord[0].xy is (0,0) everywhere in the quad.

Is there an alternative variable I can use for that? I am drawing these bars and I need to know which pixel I am at.

void JumpPad::renderBar() {
        sf::VertexArray quad(sf::Quads, 4);
        sf::FloatRect new_rect = jp_rect.getGlobalBounds();
        quad[0].position = sf::Vector2f(new_rect.left, new_rect.top);
        quad[1].position = sf::Vector2f(new_rect.left + new_rect.width, new_rect.top);
        quad[2].position = sf::Vector2f(new_rect.left + new_rect.width, new_rect.top + new_rect.height);
        quad[3].position = sf::Vector2f(new_rect.left, new_rect.top + new_rect.height);

        quad[0].texCoords = sf::Vector2f(0, 0);
        quad[1].texCoords = sf::Vector2f(1, 0);
        quad[2].texCoords = sf::Vector2f(1, 1);
        quad[3].texCoords = sf::Vector2f(0, 1);

        Game::i().rt.draw(quad);
}



// Rendering all jump pads
    sf::Shader::bind(&shader_jump_pad);
    sf::Texture::bind(nullptr);
    for(auto& jp : jumppads) jp.renderBar();
    sf::Shader::bind(nullptr);

Edit: I had to take that variable out. Passed in camera position and more, then used gl_FragCoord.

[LaurentGomila]

Shader::bind and Texture::bind are meant for use with OpenGL drawing. Why are you using them together with regular RenderTarget::draw calls?

The "right" way to do it would be:

Game::i().rt.draw(quad, &shader_jump_pad);

If you do it this way, your shader should work as before.

[naezith]

I was doing what you wrote but binding once was faster as I remember, coded it long time ago. They work nicely now without gl_TexCoord