Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mac External Frameworks Info.plist Update for AppStore Validation #1033

Closed
wants to merge 16 commits into from
Closed

Mac External Frameworks Info.plist Update for AppStore Validation #1033

wants to merge 16 commits into from

Conversation

kipbits
Copy link

@kipbits kipbits commented Dec 28, 2015

Sorry for previous confusion.
I added some lines defining CFBundleSupportedPlatforms to all the Info.plist for mac external frameworks. This allows a project using those frameworks to pass validation phase on submit to the app store review. this is related to issue 1020 based on the forum thread [SOLVED]Mac App Upload Error: (freetype).

@kipbits
Copy link
Author

kipbits commented Dec 28, 2015

sorry for original confusion

@Bromeon
Copy link
Member

Bromeon commented Dec 28, 2015

We tell you 7 pull requests is exaggerated, and as a result, you create an 8th? 😐

You can edit your pull requests after you created them. Please make use of this, it makes things more difficult for everyone if the same feature/bugfix is spread across so many issues and pull requests. It would be nice if you created only a single issue/PR in the future, not 8. Please also read our Contribution Guidelines beforehand to check whether it is actually appropriate.

@kipbits
Copy link
Author

kipbits commented Dec 28, 2015

This PR encompasses all 7 previous PR's. Sorry again. I'm a newB. Now I know

@mantognini
Copy link
Member

Could you squash everything into one commit and update this PR? Thanks.

@kipbits
Copy link
Author

kipbits commented Dec 29, 2015

oops, a minute

add a new BlendMode::Equation : ReverseSubtract
@kipbits
Copy link
Author

kipbits commented Dec 29, 2015

having trouble finding the options for consolidating commits. I'll have a look at it again in the morning

@Bromeon
Copy link
Member

Bromeon commented Dec 29, 2015

You can use git rebase -i for interactive rebasing, then you can choose what do do with every commit (-> squash). If you have a GUI such as TortoiseGit, you can also combine all the commits with 2 clicks.

This reverts commit 467ff87.
This reverts commit 418c251.
This reverts commit 51229dd.
This reverts commit 97e4946.
This reverts commit f972bfc.
This reverts commit cf2a36c.
This reverts commit 3d89009.
osx ext framework info.plist update for mac App Store validation

Squash 7 commits: Does this fix it?

#1033 (comment)

#1020

http://en.sfml-dev.org/forums/index.php?topic=19498.msg140542#msg140542
kipbits added a commit to kipbits/SFML-2.3.2-Updated-plist_altered-keyboard that referenced this pull request Dec 29, 2015
OSX external framework Info.plist update for Mac App Store validation

squash 7 commits: Does this fix it?

SFML#1033 (comment)

SFML#1020

http://en.sfml-dev.org/forums/index.php?topic=19498.msg140542#msg140542
@kipbits
Copy link
Author

kipbits commented Dec 29, 2015

OK, I started from the beginning and made a new PR: #1036

@Bromeon
Copy link
Member

Bromeon commented Dec 29, 2015

Thanks for repeatedly ignoring the advice regarding the creation of useless PRs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants