Added missing setActive virtual method to sf::RenderTarget, added set… #1157
Conversation
| /// Only one context can be current in a thread, so if you | ||
| /// want to draw OpenGL geometry to another render target | ||
| /// don't forget to activate it again. | ||
| /// |
There was a problem hiding this comment.
For RenderWindow::setActive it is specified that the previously active window (if any) will get deactivated. Here no such statement being made leaves room for interpretation. The expected behaviour is probably something obvious for someone with good knowledge of OpenGL, but I'd still recommend adding a similar statement here or, if applicable, warn the user that (s)he should make sure the previous RT was deactivated (not sure if that last statement would make sense though).
There was a problem hiding this comment.
Regarding multithreading, the documentation for RenderWindow::setActive seems more strong than this one. Should the user be expected to obey the following rule here as well?
if you want to make it active on another thread you have to deactivate it on the previous thread first if it was active.
…Active calls to OpenGL example to demonstrate proper explicit context management.
binary1248
force-pushed
the
bugfix/set_active
branch
from
196235d
to
428c481
Compare
|
Fixed the raised concerns. |
|
This PR has been added to my merge list, meaning it will be merged soon, unless someone raises any concerns. |
Added missing
setActive()virtual method tosf::RenderTargetand addedsetActive()calls to the OpenGL example to demonstrate proper explicit context management.Discussions here and here.