Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed window menu not working on OS X #1193

Merged
merged 1 commit into from Mar 7, 2017
Merged

Conversation

mantognini
Copy link
Member

This is an alternative implementation of #1180 that doesn't reintroduce #527. The issue is described in #1091.

@Foaly
Copy link
Contributor

Foaly commented Feb 21, 2017

I just tested this on OSX 10.11.6 and it worked perfectly. Thank you!

@eXpl0it3r eXpl0it3r added this to Discussion in SFML 2.5.0 Feb 21, 2017
@eXpl0it3r eXpl0it3r moved this from Discussion to Review & Testing in SFML 2.5.0 Feb 21, 2017
@mantognini mantognini added bug and removed bug labels Feb 21, 2017
Copy link
Member

@eXpl0it3r eXpl0it3r left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't fully understand what the fix does, but since it seems to work for people, I'll approve it.

@eXpl0it3r eXpl0it3r moved this from Review & Testing to Ready in SFML 2.5.0 Mar 7, 2017
@eXpl0it3r eXpl0it3r merged commit 756cb09 into master Mar 7, 2017
@eXpl0it3r eXpl0it3r deleted the bugfix/osx_window_menu branch March 7, 2017 15:43
@eXpl0it3r eXpl0it3r moved this from Ready to Merged in SFML 2.5.0 Mar 7, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
No open projects
SFML 2.5.0
  
Merged / Superseded
Development

Successfully merging this pull request may close these issues.

None yet

3 participants