Clipboard Support

[mantognini]

Based on @ricanteja work from #1204.

References:

• forum discussion (old thread)
• Clipboard Support #715
• Clipboard Support #1204

Missing:

• Android implementation (volunteer?)
• iOS implementation (volunteer?)
• testing, testing & more testing!

[mantognini]

@sol-prog, @louis-langholtz, @spacechase0, @BlueCobold: do any of you want to provide the iOS implementation? It's probably very similar to the mac one, but I can't test. :-)

[eXpl0it3r]

Would could just add a dummy implementation for Android and iOS for the time being.

[mantognini]

Alright, so I've added an empty Android implementation and one for iOS (based on Apple's doc only, didn't compile the stuff...).

[BlueCobold]

@mantognini To what version of iOS should this implementation be compatible to?

Edit: Now I'm confused, the implementation is already existing. Oh... I read your last comment now ;)

[mantognini]

@BlueCobold I don't know actually. Didn't pay too much attention to that. If you feel it could be more backward compatible, send me a patch. ;-)

[eXpl0it3r]

Just gave this another spin on my Windows 10 machine and it works fine, with no, one or multiple windows.

@BlueCobold Were you able to test the iOS implementation?
@MarioLiebisch How does the Android implementation look like?

[MarioLiebisch]

Still haven't figured out what the "correct" thread is or how to identify it. There's hardly any documentation to be found.

[eXpl0it3r]

Any progress, @MarioLiebisch?

[MarioLiebisch]

To be honest I'm so short from simply adding a Java function as a wrapper to be called…

[CelticMinstrel]

This seems like a great start, but why no image support?

[mantognini]

The goal of this PR is to get something "quickly". During the discussion for this feature, we agreed to split the work in several stages to make observable progress. The next one would be indeed adding support for images, but also for other kind of data.

[CelticMinstrel]

I see. That sounds good, then.

[eXpl0it3r]

@MarioLiebisch Can we somehow move forward on this?

[MarioLiebisch]

No progress here, revert it to the "not implemented" state for now.

[eXpl0it3r]

Removed the boilerplate code for Android and rebased onto master.

Android code can still be found on the feature/clipboard_android branch.

[ricanteja]

Woohoo! Contributed to my first major project 🥇 Thanks guys!

[Foaly]

Don't know if this is the right place for this, but I noticed a warning in the OSX clipboard implementation. In ClipboardImpl::setString line 60 the variable ok is never actually used. I don't know enough about Objective C to know if it is necessary or not.

[mantognini]

I guess it was used for debugging at some point. Shouldn't be a big deal (ok == false if the owner of the pasteboard has changed but this shouldn't happen). It's nevertheless a good thing you've spotted that one.

[Foaly]

Alright cool! I'll send a PR to fix the warning.