Added support for (some) Hat/POV axis #1248
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mantognini
commented
Jul 12, 2017
src/SFML/Window/OSX/JoystickImpl.cpp
Outdated
| break; | ||
|
|
||
| default: | ||
| sf::err() << "Unexpected usage for element of Page Generic Desktop: 0x" << std::hex << IOHIDElementGetUsage(element) << std::dec << std::endl; |
There was a problem hiding this comment.
This should be disabled in release builds.
|
Does this need adjustment for other OS? |
mantognini
force-pushed
the
bugfix/joystick
branch
from
daf9bf9
to
6d6e3f3
Compare
|
As far as I know, only Mac is concerned by this. |
mantognini
force-pushed
the
bugfix/joystick
branch
from
6d6e3f3
to
79d09a9
Compare
|
I've rebased this. I believe it can be moved to "Ready". |
eXpl0it3r
approved these changes
Nov 29, 2017
eXpl0it3r
force-pushed
the
bugfix/joystick
branch
from
79d09a9
to
883ec93
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds support for POV (of Hat) axes. It was solely tested with a Dualshock 4 but should gracefully fail (with a report on
sf::err) when the assumptions behind this implementation don't hold.