Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Updated OpenAL Soft to 1.18.1 for Windows. #1260

Merged
merged 1 commit into from Aug 28, 2017
Merged

Updated OpenAL Soft to 1.18.1 for Windows. #1260

merged 1 commit into from Aug 28, 2017

Conversation

eXpl0it3r
Copy link
Member

This should fix #1247.

@eXpl0it3r eXpl0it3r added this to the 2.5 milestone Aug 3, 2017
@eXpl0it3r eXpl0it3r self-assigned this Aug 3, 2017
@eXpl0it3r
Copy link
Member Author

Just tested all the binaries provided by our CI system and they all work fine. If someone has Windows XP running or some other system than Windows 10, feel free to test this as well.

@eXpl0it3r eXpl0it3r added this to Review & Testing in SFML 2.5.0 Aug 4, 2017
@mantognini
Copy link
Member

Should we take this opportunity to update the binaries for other OSes as well? E.g. OS X is at 1.16.

@eXpl0it3r
Copy link
Member Author

Feel free to do so. 😉

@mantognini
Copy link
Member

Okay, I'll try to find the time before the end of the month. Don't block this one on me though, I'll create another PR. ;-)

@eXpl0it3r
Copy link
Member Author

Tested on Windows XP as well.

How's it looking @mantognini? Otherwise I'll just go ahead and set this up for merging.

@mantognini
Copy link
Member

Go ahead, I won't have time to do this soon. And in any case it will be in another PR.

If someone else wants to do it, please have fun. :)

@eXpl0it3r
Copy link
Member Author

If someone wants to give this a positive review, as I can't do it myself. 😉

@eXpl0it3r eXpl0it3r moved this from Review & Testing to Ready in SFML 2.5.0 Aug 23, 2017
@eXpl0it3r eXpl0it3r merged commit 6b3061d into master Aug 28, 2017
@eXpl0it3r eXpl0it3r moved this from Ready to Merged / Superseded in SFML 2.5.0 Aug 28, 2017
@eXpl0it3r eXpl0it3r deleted the feature/update_openal branch August 28, 2017 11:48
@aBlueShadow aBlueShadow mentioned this pull request Dec 15, 2017
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@binary1248 binary1248 binary1248 approved these changes

Assignees

@eXpl0it3r eXpl0it3r

Labels
feature m:sfml-audio p:windows
Projects
No open projects
SFML 2.5.0
  
Merged / Superseded
Milestone
2.5
Development

Successfully merging this pull request may close these issues.

The current openal32.dll appears to have problems with new hardware and Windows 10
3 participants
@eXpl0it3r @mantognini @binary1248