Fix X11 key repeat handling not filtering out events from other windows

[binary1248]

Fixes #1223.
Closes #1230.

[eXpl0it3r]

@naezith @texus Can you give this a spin?

[texus]

This solves the issues on both my linux computers. 👍

[LaurentGomila]

Is there a reason to do that if m_keyRepeat is false?

[eXpl0it3r]

I do think so, as it has to fulfill the two tasks mentioned at the function top.

• Discard duplicated KeyRelease events when KeyRepeatEnabled is true
• Discard both duplicated KeyPress and KeyRelease events when KeyRepeatEnabled is false

When repeat is true it will ignore the repeated KeyRelease event that X generates.

When repeat is false it will erase the repeated KeyPress event from the queue and ignore the repeated KeyRelease event.

[LaurentGomila]

Sorry, I didn't read the code carefully 😸

[eXpl0it3r]

Tested on Debian x64 Gnome. Was able to reproduce the issue and this PR fixed it.

[eXpl0it3r]

Works as intended and makes sense to me in the context.

[naezith]

Sorry for testing late, I just did. Absolutely nothing changed for me. #1223 is still there. @eXpl0it3r @binary1248

Linux (Ubuntu 16.04)

[eXpl0it3r]

Having tested and reviewed the code myself, I don't trust your result. Did you make sure that the correct library is linked and not an old version.

If the new code is actually running, then the only reason it fails must be because the timestamps reported by X don't match, which I can't think is happening as three independent testers report it to work fine.

[naezith]

@eXpl0it3r I manually went into Commits of this, did "Browse the repository at this point in the history", then downloaded .zip of whole repository from that page. Checked if the changes are there. Renamed my original SFML and build folders. Put this new one there and changed the name to SFML, generated files with cmake, then built it with "make" into the build folder. Then ran this script I wrote which copies the libs to the game path:

#!/bin/bash

game_path="/home/naezith/.steam/steam/steamapps/common/Remnants of Naezith Beta"
linux_content="/media/naezith/SSD/steamworks_sdk/tools/ContentBuilder/content/linux_content"
TARGETS=("$linux_content/lib/" "$game_path/lib/") 

for TARGET_PATH in "${TARGETS[@]}"; do
	echo " "
	echo ">> NEW TARGET PATH:""$TARGET_PATH"

	# Copy SFML
	SFML_PATH=/home/naezith/sfml-build/lib/
	SFML_LIBS=(audio graphics window network system)

	for f in "${SFML_LIBS[@]}"; do
		path=$SFML_PATH"libsfml-"$f".so.2.4"
		echo $path
		cp $path "$TARGET_PATH"
	done 
done

Then I opened the SFML project and compiled it, and tested. Is there any suspicious part in this? Maybe I am doing this testing thing wrong.

[naezith]

My bad, there was SFML installed directly to /usr/local/lib kind of folders. They were prioritized I guess. I cleaned them now. I did the same stuff as I explained and now it works! Thanks a lot.