Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Android sends Delete event instead of Backspace #1309

Closed
texus opened this issue Oct 22, 2017 · 4 comments
Closed

Android sends Delete event instead of Backspace #1309

texus opened this issue Oct 22, 2017 · 4 comments
Labels
bug m:sfml-window p:android
Projects
Android Backlog SFML 2.5.0
Milestone
2.5

Comments

@texus
Copy link
Contributor

texus commented Oct 22, 2017 •
edited

SFML maps the AKEYCODE_DEL event to Keyboard::Delete (WindowImplAndroid.cpp#L623) while AKEYCODE_DEL is actually the backspace key. The real delete key is AKEYCODE_FORWARD_DEL.

It was mentioned before in this forum post, but it seems like it has been overlooked.
@eXpl0it3r eXpl0it3r added this to Backlog in Android Backlog Jan 25, 2018
@Foaly
Copy link
Contributor

Foaly commented Jan 29, 2018

@texus I could write a fix for this, but I have no way of testing it. Would you be able to test, if I write a PR?

@texus
Copy link
Contributor Author

texus commented Jan 29, 2018

The fix is pretty trivial (just change that line and add another case statement), so there isn't much that really has to be tested. But yeah, if you create PR then I will run it to verify that it works.

@Foaly Foaly mentioned this issue Jan 29, 2018
Closed
@Foaly
Copy link
Contributor

Foaly commented Jan 29, 2018 •
edited

Awesome! Yeah test is maybe not the right wording in this trivial case. It would be great if you can verify that it fixes the bug as intended. You can find the PR here #1362. If somebody from the team kicks the buildbot there will even be binarys.

@eXpl0it3r eXpl0it3r added this to Discussion in SFML 2.5.0 via automation Jan 29, 2018
@eXpl0it3r eXpl0it3r added this to the 2.5 milestone Jan 29, 2018
@eXpl0it3r eXpl0it3r moved this from Discussion to Review & Testing in SFML 2.5.0 Feb 10, 2018
@eXpl0it3r eXpl0it3r moved this from Review & Testing to Ready in SFML 2.5.0 Feb 11, 2018
@eXpl0it3r
Copy link
Member

Fixed with #1362 and merged in 1862946

SFML 2.5.0 automation moved this from Ready to Merged / Superseded Feb 15, 2018
Android Backlog automation moved this from Backlog to Done Feb 15, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug m:sfml-window p:android
Projects
Android Backlog
  
Done
SFML 2.5.0
  
Merged / Superseded
Milestone
2.5
Development

Successfully merging a pull request may close this issue.

Return correct key code for delete/backspace on android. Foaly/SFML
3 participants
@eXpl0it3r @Foaly @texus