New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Return correct key code for delete/backspace on android. #1362
Conversation
This is a good example of why even trivial fixes need to be tested. The API has to be 13 or higher or it won't compile. The ANDROID_API_MIN currently still has a default value of 9, where AKEYCODE_FORWARD_DEL apparently didn't exist yet. I think the minimum version can be increased without any issues, even API 13 (android 3.2) is more than 7 years old already. |
Funny somehow I had the gut feeling it would be a good idea to have this tested 😄 Could you test the new version? |
a4768e4
to
a2bb2b4
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Latest tools will no longer allow you to build anything under API 14, so I'd say it's save to just bump the minimum version to 14 now.
a2bb2b4
to
0a8a2de
Compare
14 it is then! |
0a8a2de
to
015c774
Compare
Works without problems now. I found a keyboard with a delete key so I can confirm that both backspace and delete works. |
Thats awesome! Thank you very much for testing! I guess if @MarioLiebisch closes his review this can be merged :) |
Yeah, changes are fine, but not sure we should wait for #1350 with this. You'll basically need both changes to properly compile without this bug (and others). |
I don't really see how #1350 is dependent on this, so I think this is ready for merging now! :) |
Small conflict to resolve since the other Android bit has been merged. 🙂 |
Also increased minimum Android API version to 14.
015c774
to
b1294d2
Compare
Ah I see it now :D Updated! |
Merged in 1862946 |
This fixes #1309.