Fixed crash with application messing hardware detection #1323
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eXpl0it3r
approved these changes
Nov 28, 2017
This prevents crashes & reduces the amount of logging but does not actually make isKeyPressed work when using e.g. TeamViewer.
eXpl0it3r
force-pushed
the
bugfix/osx_no_keyboard
branch
from
0a83a7f
to
dd307cc
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This prevents crashes & reduces the amount of logging but does not actually make isKeyPressed work when using e.g. TeamViewer. I think it is not worth spending more time one this (unless a lot of people complain about it, of course).
I suggest we move forward quickly on this one because it affected only me so far, and because the bugfix is straightforward:
freeUpwasn't resetting some field properly, which caused a crash when calling it again in (e.g.) the dtor.