Fixed various type conversion/comparison warnings. #1325
Conversation
src/SFML/Network/Ftp.cpp
Outdated
| @@ -463,7 +463,7 @@ Ftp::Response Ftp::getResponse() | |||
| } | |||
|
|
|||
| // Save the remaining data for the next time getResponse() is called | |||
| m_receiveBuffer.assign(buffer + in.tellg(), length - in.tellg()); | |||
| m_receiveBuffer.assign(buffer + static_cast<std::streamoff>(in.tellg()), length - static_cast<std::size_t>(in.tellg())); | |||
There was a problem hiding this comment.
The first cast should not be needed.
There was a problem hiding this comment.
Visual Studio 2015 and 2017 32bits still complain about it.
According to cppreference std::streamoff is usually typedef-ed to long long and for the pointer manipulation you need an int thus there needs to be an explicit cast (for the architecture that uses 32bits ints).
There was a problem hiding this comment.
Ah, sorry I though it was the same type (std::streamoff vs std::streampos). And why not std::size_t by the way?
There was a problem hiding this comment.
I picked std::streamoff since that's what the compiler expected and converts to. I could try std::size_t as well, even though that will be unsigned int and not int, wouldn't it?
There was a problem hiding this comment.
The first argument of assign is a const char*, which buffer + <any integral type> should produce no matter what the integral type is. So I don't get why we need a std::streamoff specifically.
There was a problem hiding this comment.
Changed it to std::size_t. 🙂
eXpl0it3r
force-pushed
the
bugfix/compiler_type_warnings
branch
from
6f32826
to
73b43c2
Compare
eXpl0it3r
force-pushed
the
bugfix/compiler_type_warnings
branch
from
73b43c2
to
247b031
Compare
I have applied some fixed for the various type conversion/comparison warnings Visual Studio has been complaining about for a while now.
I wasn't certain for every place if the change was done properly and for some places it certainly raises the question if the chosen type is good.
There's one remaining warning that we can't easily fix. It's in the network module when calling
::send(). Linux implements the socket send function with asize_t, while Windows usesint, causing a mismatch between platforms.