Fix for broken text when the font is reloaded.

[Foaly]

Hi!
I took the liberty to write an update for this PR #769. There has been no activity in the last 2 years. I updated the implementaion to the decision in the forum discussion. https://en.sfml-dev.org/forums/index.php?topic=14019.30
Hopefully we can fix the bug soon!

[binary1248]

Comment looks weird, either add an apostrophe or leave the s away from fonts.

[binary1248]

No need to reorder the declarations here... Add a single line instead of modifying 3.

[Foaly]

I though having them alphabetically made more sense then random.

[binary1248]

👍

[binary1248]

In certain situations, this will dereference a NULL pointer causing undefined behaviour. The check for m_font is already done further down. Either move it up or move this down.

[binary1248]

Same as above.

[binary1248]

Just noticed that m_fontTextureId isn't initialized to a value prior to this line, meaning that in the comparison above, it would contain an undefined value.

[Foaly]

👍 fixed

[Foaly]

By the way if someone wants to test I've been using exploiters old test code

#include <SFML/Graphics.hpp>

int main()
{
    sf::RenderWindow window(sf::VideoMode(800, 600), "Example");

    bool broken = false;

    const std::string filename("a font");

    sf::Font font;
    font.loadFromFile(filename);

    sf::Text text("font is broken", font, 30u);

    // run the program as long as the window is open
    while (window.isOpen())
    {
        // check all the windows events
        sf::Event event;
        while (window.pollEvent(event))
        {
            // "close requested" event: we close the window
            if (event.type == sf::Event::Closed)
                window.close();

            else if (event.type == sf::Event::KeyReleased) {
                // close if escape key was pressed
                if (event.key.code == sf::Keyboard::Escape) {
                    window.close();
                }

                if (!broken)
                {
                    broken = true;
                    font.loadFromFile(filename);
                    //text.setFont(font);
                    //text.setCharacterSize(30u);
                    //text.setString("font is broken");
                }
            }
        }

        // clear the window to black
        window.clear();

        window.draw(text);

        // display the windows content
        window.display();
    }
    return 0;
}

[mantognini]

Works like a charm on mac. 👍

[binary1248]

Just noticed that m_fontTextureId isn't initialized to a value prior to this line, meaning that in the comparison above, it would contain an undefined value.

[binary1248]

👍

[Foaly]

I think this can be merged now.