Timeout argument causes problems in sf::TcpSocket::connect()

[Unarelith]

I tried using sf::TcpSocket recently, and I decided to use the timeout argument.
When I set it to, let's say sf::seconds(5), and if it fails to connect once, the instance of the socket will no longer try to connect, and always fail.

So is this behavior intended or did you just forget to reset timeout state after a connection failed?

Library: SFML 2.4.2-4
OS: ArchLinux x86_64

[eXpl0it3r]

Not the same, but similarly trying to reuse a socket, it seems there's an oversight in actually closing the closing the socket before trying to establish a new one.

Since the original poster of the thread didn't end up creating an issue, I'll just take this one then. For further posting, keep in mind though that we prefer to first discuss issues on the forum, as it often turns out to be misconfigurations or general user errors and we like to keep the issue track for confirmed problems.

[eXpl0it3r]

@LaurentGomila Do you think, simply adding close() within in the connect() function is enough or are the some implications to keep in mind?

[LaurentGomila]

"Reusing sockets" is something that should be carefully reviewed in the whole network module, I see that similar functions (TcpListener::listen, UdpSocket::bind, ...) have similar behaviour, ie. they don't do anything specific if the socket already exists, while they probably should.

[binary1248]

@Quent42340 Try out PR #1408.