Fixed socket reuse not conforming to documentation

[binary1248]

Fixes #1346 and the scenarios listed here.

Test with:

#include <SFML/Network.hpp>
#include <iostream>

#define TEST1

int main()
{

#if defined(TEST1)

    sf::TcpListener l;
    l.listen(2016);
    l.listen(2017);

    sf::TcpSocket s;
    if (s.connect(sf::IpAddress::LocalHost, 2017) == sf::Socket::Done)
        std::cout << "This message should be displayed\n";

#elif defined(TEST2)

    sf::TcpListener l;
    l.listen(2017);

    sf::TcpSocket sock;
    if (sock.connect(sf::IpAddress::LocalHost, 2017) == sf::Socket::Done)
        std::cout << "This message should be displayed\n";

    if (sock.connect({1,2,3,4}, 2017) == sf::Socket::Done)
        std::cout << "This message should NOT be displayed\n";

#elif defined(TEST3)

    sf::TcpListener l;
    l.listen(2017);

    sf::TcpSocket s;
    if (s.connect({1,2,3,4}, 2017, sf::milliseconds(200)) == sf::Socket::Done)
        std::cout << "This message should NOT be displayed\n";

    if (s.connect(sf::IpAddress::LocalHost, 2017) == sf::Socket::Done)
        std::cout << "This message should be displayed\n";

#elif defined(TEST4)

    char data[5];
    std::size_t size = sizeof(data);
    sf::IpAddress address;
    unsigned short port;

    sf::UdpSocket s;
    s.bind(2016);
    s.bind(2017);

    if (s.send("Test", 5, sf::IpAddress::LocalHost, 2017) == sf::Socket::Done)
        std::cout << "This message should be displayed\n";

    if (s.receive(reinterpret_cast<void*>(data), size, size, address, port) == sf::Socket::Done)
        std::cout << "This message should be displayed\n";

#endif

    char ch;
    std::cin >> ch;
}

All test scenarios should print or not print the corresponding messages. Without this patch they would all fail.

[LaurentGomila]

Looks good 👍