Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Generate shape outline vertices only if necessary. #1356

Merged
merged 1 commit into from Feb 10, 2018
Merged

Generate shape outline vertices only if necessary. #1356

merged 1 commit into from Feb 10, 2018

Conversation

Foaly
Copy link
Contributor

@Foaly Foaly commented Jan 26, 2018 •
edited by eXpl0it3r

Improved the logic of the shape class so that the outline vertices are only updated if they exist.

Original, now abandoned #925

@eXpl0it3r eXpl0it3r mentioned this pull request Jan 26, 2018
Closed
3 tasks
@eXpl0it3r eXpl0it3r added this to Discussion in SFML 2.5.0 via automation Jan 26, 2018
@eXpl0it3r eXpl0it3r added this to the 2.5 milestone Jan 26, 2018
@eXpl0it3r eXpl0it3r moved this from Discussion to Ready in SFML 2.5.0 Jan 26, 2018
@Foaly
Copy link
Contributor Author

Foaly commented Feb 8, 2018

This is a really small fix. @LaurentGomila @Bromeon would one of you guys mind reviewing? Thanks :)

MarioLiebisch
MarioLiebisch reviewed Feb 8, 2018
View reviewed changes
Copy link
Member

@MarioLiebisch MarioLiebisch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks fine to me.

MarioLiebisch
MarioLiebisch approved these changes Feb 8, 2018
View reviewed changes
Copy link
Member

@MarioLiebisch MarioLiebisch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks fine to me.

@MarioLiebisch
Copy link
Member

Don't forget to rebase it onto the current master branch.

@eXpl0it3r
Copy link
Member

Don't forget to rebase it onto the current master branch.

Doesn't really matter as long as there's no conflict. It just won't auto close. 😉

@Foaly Foaly force-pushed the bugfix/outline_optimization branch from 63c09b3 to 14dd503 Compare February 8, 2018 22:12
@Foaly
Copy link
Contributor Author

Foaly commented Feb 8, 2018

Thanks! I rebased to make it easier :)

LaurentGomila
LaurentGomila approved these changes Feb 9, 2018
View reviewed changes
Copy link
Member

@LaurentGomila LaurentGomila left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I just gave this a quick look, but it seems to be ok. If it has been properly tested, I guess it can be merged.

@eXpl0it3r eXpl0it3r merged commit 14dd503 into SFML:master Feb 10, 2018
SFML 2.5.0 automation moved this from Ready to Merged / Superseded Feb 10, 2018
@Foaly Foaly deleted the bugfix/outline_optimization branch February 10, 2018 17:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@LaurentGomila LaurentGomila LaurentGomila approved these changes

@MarioLiebisch MarioLiebisch MarioLiebisch approved these changes

@Bromeon Bromeon Awaiting requested review from Bromeon

Assignees
No one assigned
Labels
feature m:sfml-graphics
Projects
No open projects
SFML 2.5.0
  
Merged / Superseded
Milestone
2.5
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@Foaly @MarioLiebisch @eXpl0it3r @LaurentGomila