Fixed Win32 modifier keys handling #1357
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eXpl0it3r
approved these changes
Jan 26, 2018
There was a problem hiding this comment.
Some more reasoning behind the change would have been nice, but GetKeyState is indeed the correct function in this regard.
|
Indeed, looks more correct. Out of curiosity, what made you work on this fix? Did you experience problems? |
LaurentGomila
approved these changes
Jan 27, 2018
binary1248
approved these changes
Jan 27, 2018
|
Indeed, with a debugging feature that introduced occasional lags, Shift became out of sync with the actual keystrokes, that was pretty funny. |
|
Merged in 1062e95 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixed Win32 modifier keys handling so that
alt/control/shift/systemvalues inEvent::KeyEventreflect their status at the time ofKeyPressed/KeyReleased.Does not affect
Keyboard::isKeyPressed(), which can still be used to access the keyboard state directly.