Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Turned the header image in readme.md into a link. #1368

Closed
wants to merge 1 commit into from

Conversation

Foaly
Copy link
Contributor

@Foaly Foaly commented Feb 8, 2018

I've always found it irritating, that the header logo in readme.md is not a link to the website. When changing it I discovered a bunch of http links, so I changed them all to https. For the smaller website where I didn't know if they support it, I've checked.

doc/footer.html Outdated
Copyright © Laurent Gomila  :: 
Documentation generated by <a href="http://www.doxygen.org/" title="doxygen website">doxygen</a> &nbsp;::&nbsp;
Documentation generated by <a href="https://www.stack.nl/~dimitri/doxygen/" title="doxygen website">doxygen</a> &nbsp;::&nbsp;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would keep this. I mean HTTP links aren't really any issue and who knows if that weird URL will move one day, while doxygen.org is more likely to stay.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense I guess.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

http://www.doxygen.org/ is a redirect to that dutch URL though.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I know and? As I said, doxygen.org is more likely to stay than that Dutch URL.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah probably right!

readme.md Outdated
@@ -19,21 +19,21 @@ SFML is a simple, fast, cross-platform and object-oriented multimedia API. It pr

## Download

You can get the latest official release on [SFML's website](http://www.sfml-dev.org/download.php). You can also get the current development version from the [Git repository](https://github.com/SFML/SFML).
You can get the latest official release on [SFML's website](https://www.sfml-dev.org/download.php). You can also get the current development version from the [Git repository](httpss://github.com/SFML/SFML).
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Interesting protocol you got there. 😉

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I ran one command twice... I knew I would miss something 😄

@@ -145,7 +145,7 @@ IpAddress IpAddress::getPublicAddress(Time timeout)
{
// The trick here is more complicated, because the only way
// to get our public IP address is to get it from a distant computer.
// Here we get the web page from http://www.sfml-dev.org/ip-provider.php
// Here we get the web page from https://www.sfml-dev.org/ip-provider.php
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This can't be changed! 🙀

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why not? the site is also reachable with https?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sf::TcpSocket is unable to do SSL.

Besides, the comment no longer matches the code if you do this.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yep I mistook it for a documentation in a header.

WGL_ARB_create_context_profile
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What is this change ❔

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Newline at end of file.

@@ -20,7 +20,7 @@
# This tag specifies the encoding used for all characters in the config file
# that follow. The default is UTF-8 which is also the encoding used for all text
# before the first occurrence of this tag. Doxygen uses libiconv (or the iconv
# built into libc) for the transcoding. See http://www.gnu.org/software/libiconv
# built into libc) for the transcoding. See https://www.gnu.org/software/libiconv
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is an auto-generated file, I wouldn't really edit it, but I guess it doesn't hurt either, so lets keep the changes.

readme.md Outdated
* The [community forum](http://en.sfml-dev.org/forums/) ([French](http://fr.sfml-dev.org/forums/))
* The [official tutorials](https://www.sfml-dev.org/tutorials/)
* The [online API documentation](https://www.sfml-dev.org/documentation/)
* The [community wiki](httpss://github.com/SFML/SFML/wiki/)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this the super secure protocol? 😉

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yep http super secure is the new telnet!

@eXpl0it3r eXpl0it3r added this to Discussion in SFML 2.5.0 via automation Feb 8, 2018
@eXpl0it3r eXpl0it3r added this to the 2.5 milestone Feb 8, 2018
@eXpl0it3r eXpl0it3r self-assigned this Feb 8, 2018
@eXpl0it3r eXpl0it3r moved this from Discussion to Requires Adjustments in SFML 2.5.0 Feb 8, 2018
@Foaly
Copy link
Contributor Author

Foaly commented Feb 8, 2018

I will send an update later tonight!

@Foaly
Copy link
Contributor Author

Foaly commented Feb 8, 2018

Updated!

Updated all links to use https (tested).
@eXpl0it3r eXpl0it3r moved this from Requires Adjustments to Ready in SFML 2.5.0 Feb 10, 2018
@eXpl0it3r
Copy link
Member

Merged in 989367e

@eXpl0it3r eXpl0it3r closed this Feb 10, 2018
SFML 2.5.0 automation moved this from Ready to Merged / Superseded Feb 10, 2018
@Foaly Foaly deleted the feature/https_links branch February 10, 2018 17:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
No open projects
SFML 2.5.0
  
Merged / Superseded
Development

Successfully merging this pull request may close these issues.

None yet

3 participants