New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Turned the header image in readme.md into a link. #1368
Conversation
doc/footer.html
Outdated
Copyright © Laurent Gomila :: | ||
Documentation generated by <a href="http://www.doxygen.org/" title="doxygen website">doxygen</a> :: | ||
Documentation generated by <a href="https://www.stack.nl/~dimitri/doxygen/" title="doxygen website">doxygen</a> :: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would keep this. I mean HTTP links aren't really any issue and who knows if that weird URL will move one day, while doxygen.org is more likely to stay.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Makes sense I guess.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
http://www.doxygen.org/ is a redirect to that dutch URL though.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I know and? As I said, doxygen.org is more likely to stay than that Dutch URL.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah probably right!
readme.md
Outdated
@@ -19,21 +19,21 @@ SFML is a simple, fast, cross-platform and object-oriented multimedia API. It pr | |||
|
|||
## Download | |||
|
|||
You can get the latest official release on [SFML's website](http://www.sfml-dev.org/download.php). You can also get the current development version from the [Git repository](https://github.com/SFML/SFML). | |||
You can get the latest official release on [SFML's website](https://www.sfml-dev.org/download.php). You can also get the current development version from the [Git repository](httpss://github.com/SFML/SFML). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Interesting protocol you got there. 😉
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I ran one command twice... I knew I would miss something 😄
src/SFML/Network/IpAddress.cpp
Outdated
@@ -145,7 +145,7 @@ IpAddress IpAddress::getPublicAddress(Time timeout) | |||
{ | |||
// The trick here is more complicated, because the only way | |||
// to get our public IP address is to get it from a distant computer. | |||
// Here we get the web page from http://www.sfml-dev.org/ip-provider.php | |||
// Here we get the web page from https://www.sfml-dev.org/ip-provider.php |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This can't be changed! 🙀
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why not? the site is also reachable with https?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
sf::TcpSocket
is unable to do SSL.
Besides, the comment no longer matches the code if you do this.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yep I mistook it for a documentation in a header.
WGL_ARB_create_context_profile |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What is this change ❔
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Newline at end of file.
@@ -20,7 +20,7 @@ | |||
# This tag specifies the encoding used for all characters in the config file | |||
# that follow. The default is UTF-8 which is also the encoding used for all text | |||
# before the first occurrence of this tag. Doxygen uses libiconv (or the iconv | |||
# built into libc) for the transcoding. See http://www.gnu.org/software/libiconv | |||
# built into libc) for the transcoding. See https://www.gnu.org/software/libiconv |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is an auto-generated file, I wouldn't really edit it, but I guess it doesn't hurt either, so lets keep the changes.
readme.md
Outdated
* The [community forum](http://en.sfml-dev.org/forums/) ([French](http://fr.sfml-dev.org/forums/)) | ||
* The [official tutorials](https://www.sfml-dev.org/tutorials/) | ||
* The [online API documentation](https://www.sfml-dev.org/documentation/) | ||
* The [community wiki](httpss://github.com/SFML/SFML/wiki/) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is this the super secure protocol? 😉
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yep http super secure is the new telnet!
I will send an update later tonight! |
015efe3
to
487513e
Compare
Updated! |
Updated all links to use https (tested).
487513e
to
5fbcaaa
Compare
Merged in 989367e |
I've always found it irritating, that the header logo in readme.md is not a link to the website. When changing it I discovered a bunch of http links, so I changed them all to https. For the smaller website where I didn't know if they support it, I've checked.