New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Android: Updated the example to build with gradle #1393
Conversation
ab63f22
to
64578a3
Compare
I assume this isn't SFML 2.5 ready, right? Will you find time anytime soon, to get it ready? |
As far as I know the issues I've mentioned aren't related to the demo itself. It just needs testing/feedback. Considering the current demo in the master branch is broken/unusable with up to date tools anyway, including this should be as good (or better) than keeping the current state. |
@MarioLiebisch The CI build failed. Anything that needs to be update on the CI or with this branch? |
The whole build process for the example is outdated (starting at step 20). You'll need Gradle installed, then only run You might need a local
|
Is there a tutorial or step by step guide for this somewhere? 😛 |
It's really just that. Get Gradle, standalone or by using npm, and invoke it for everything:
|
There... after 2 hours of trial and error it actually builds. Better merge this quick since all other branches will fail to build on Android now. 😁 |
If I run In order to build for x86 I also had to edit app/build.gradle as it has the armeabi-v7a hardcoded. Gradle also doens't seem to run in my gnome-terminal, I had to run it using xterm or add I haven't gotten the apk to actually run without crashing, but I'll just wait with that until SFML 2.6, hopefully things will be more stable by then. |
ah, sorry, yeah, the correct/valid targets are |
Are you really sure? 😁 I tried those and they didn't work. I ended up having to run |
Hm yeah, haven't touched it for too long it seems. For some reason there's a target |
64578a3
to
f4c25ac
Compare
@MarioLiebisch Can you check why this fails? https://ci.sfml-dev.org/#/builders/12/builds/143 |
Patching fails due to missing file or file permission. No idea, but that's not really related to the changes from what I can see. |
It was still based on a revision before this PR was merged. Can be safely ignored. |
If that's not the issue, what's the output of |
Whatever it is supposed to be. 😁 All the other branches based off a revision after this PR build correctly, so no need to invest more effort here. |
Ah okay, so it was really just that patching issue then. Fine with me. :D |
Ah sorry didn't think it through properly 😄 |
This PR is mostly for visibility and you should consider it a work in progress.
It basically addresses #1311 and supercedes/includes #1315.
This updates the Android example to use Gradle rather than Ant for building.
To configure the example, simply run
gradle
. To build it, rungradle build
, and to install it, rungradle installDebug
orgradle installRelease
.Here are some known and so far not fixed issues (at least on my Nexus 5), but I don't think they're actually demo project related:
canary.wav
fails for me.Feedback and bugfixes are appreciated, I'm really short on time right now. :(