Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removed unnecessary cmake osx deployment target value #1467

Closed
wants to merge 1 commit into from
Closed

Removed unnecessary cmake osx deployment target value #1467

wants to merge 1 commit into from

Conversation

JonnyPtn
Copy link
Contributor

@JonnyPtn JonnyPtn commented Aug 9, 2018

  • Has this change been discussed on the forum or in an issue before?
  • Does the code follow the SFML Code Style Guide?
  • Have you provided some example/test code for your changes?

Description

Addresses #1436

Tasks

  • Tested on macOS
  • Tested on iOS

How to test this PR?

If you're on macOS, check this doesn't break your build

Copy link

@ssrobins ssrobins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I took the code from osx_deploy_target branch in the JonnyPtn/SFML repo and built it in my build system, using CMake to generate Makefiles and Xcode project files.

I commented out this line in my build system, which I was using as a workaround to the reported difficulty I was having:
set(CMAKE_OSX_DEPLOYMENT_TARGET "10.9" CACHE STRING "Minimum OS X deployment version" FORCE)

SFML and all games that use it built fine in both configurations. gtest, which had issues with the 10.7 target setting, built fine too.

My environment:
MacBook pro 13-inch retina, early 2015
macOS 10.13.6
Xcode 9.4.1

@eXpl0it3r eXpl0it3r added this to Discussion in SFML 2.5.1 via automation Aug 12, 2018
@eXpl0it3r eXpl0it3r added this to the 2.5.1 milestone Aug 12, 2018
@eXpl0it3r eXpl0it3r moved this from Discussion to Ready in SFML 2.5.1 Aug 13, 2018
@eXpl0it3r
Copy link
Member

Merged in e3c6509

@eXpl0it3r eXpl0it3r closed this Aug 13, 2018
SFML 2.5.1 automation moved this from Ready to Done Aug 13, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
No open projects
SFML 2.5.1
  
Done
Development

Successfully merging this pull request may close these issues.

None yet

3 participants