Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed missing checks for empty vertex arrays when updating the vertex buffers in sf::Text. #1560

Merged
merged 1 commit into from Feb 25, 2019

Conversation

binary1248
Copy link
Member

@binary1248 binary1248 commented Feb 20, 2019

Fixes #1558.

Test with the following in debug configuration (asserts enabled):

#include <SFML/Graphics.hpp>

int main()
{
    sf::RenderTexture foo;
    sf::Font bar;
    sf::Text baz(" ", bar);
    foo.draw(baz); // Debug assert 1 & 2
    baz.setFillColor(sf::Color::Green);  // Debug assert 3
    baz.setOutlineColor(sf::Color::Green);  // Debug assert 4
}

@eXpl0it3r eXpl0it3r added this to Discussion in SFML 2.6.0 via automation Feb 20, 2019
@eXpl0it3r eXpl0it3r added this to the 2.6 milestone Feb 20, 2019
@eXpl0it3r eXpl0it3r moved this from Discussion to Ready in SFML 2.6.0 Feb 20, 2019
@eXpl0it3r eXpl0it3r merged commit 4043f71 into master Feb 25, 2019
SFML 2.6.0 automation moved this from Ready to Done Feb 25, 2019
@eXpl0it3r eXpl0it3r deleted the bugfix/text_empty_vertices branch February 25, 2019 21:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
No open projects
SFML 2.6.0
  
Done
Development

Successfully merging this pull request may close these issues.

None yet

3 participants