Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: Win32 no longer hides cursor when hovering title bar. #1570

Merged
merged 1 commit into from May 13, 2019

Conversation

eigenbom
Copy link
Contributor

  • Has this change been discussed on the forum or in an issue before?
  • Does the code follow the SFML Code Style Guide?
  • Have you provided some example/test code for your changes?

Description

This PR is related to issue #1569.

When you hide the mouse cursor in Windows the cursor does not re-appear when hovering the title bar and window frame. It does re-appear on other platforms and also re-appears if you set a blank image cursor - this patch fixes this inconsistency.

Tasks

  • Tested on Windows

How to test this PR?

Hover over the title bar or window frame and the cursor should re-appear.

#include <SFML/Window.hpp>
int main()
{
    sf::Window window(sf::VideoMode(400, 300), "Cursor Bug");
    window.setMouseCursorVisible(false);
    while (window.isOpen())
    {
        sf::Event event;
        while (window.pollEvent(event))
        {
            if (event.type == sf::Event::Closed)
                window.close();
        }
        window.display();
    }
}

@eXpl0it3r eXpl0it3r added this to Discussion in SFML 2.6.0 via automation Mar 17, 2019
@eXpl0it3r eXpl0it3r added this to the 2.6 milestone Mar 17, 2019
Copy link
Member

@LaurentGomila LaurentGomila left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

@eXpl0it3r eXpl0it3r moved this from Discussion to Ready in SFML 2.6.0 Mar 17, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
No open projects
SFML 2.6.0
  
Done
Development

Successfully merging this pull request may close these issues.

None yet

4 participants