Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Initialise m_context correctly in SFContext constructors #1610

Merged
merged 1 commit into from Sep 1, 2019
Merged

Initialise m_context correctly in SFContext constructors #1610

merged 1 commit into from Sep 1, 2019

Conversation

JonnyPtn
Copy link
Contributor

This prevents the segfault mentioned in #1582 and will make it exit gracefully if a pixel format isn't found

@JonnyPtn JonnyPtn mentioned this pull request Aug 31, 2019
Closed
LaurentGomila
LaurentGomila approved these changes Aug 31, 2019
View reviewed changes
Copy link
Member

@LaurentGomila LaurentGomila left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good 👍

@eXpl0it3r eXpl0it3r added this to Discussion in SFML 2.6.0 via automation Aug 31, 2019
@eXpl0it3r eXpl0it3r added this to the 2.6 milestone Aug 31, 2019
@eXpl0it3r eXpl0it3r moved this from Discussion to Ready in SFML 2.6.0 Aug 31, 2019
@eXpl0it3r eXpl0it3r merged commit b00317e into SFML:master Sep 1, 2019
SFML 2.6.0 automation moved this from Ready to Done Sep 1, 2019
@dogunbound dogunbound mentioned this pull request May 17, 2023
Merged
@ChrisThrasher ChrisThrasher mentioned this pull request Jun 23, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@LaurentGomila LaurentGomila LaurentGomila approved these changes

@binary1248 binary1248 binary1248 approved these changes

Assignees
No one assigned
Labels
bug m:sfml-window p:macos
Projects
No open projects
SFML 2.6.0
  
Done
Milestone
2.6
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@JonnyPtn @LaurentGomila @binary1248 @eXpl0it3r