Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changed Doxygen single-line comment format #1623

Merged
merged 1 commit into from Jan 2, 2020

Conversation

MarioLiebisch
Copy link
Member

Single line comments starting with /// are interpreted by Microsoft Visual Studio as documentation containing XML code.

Therefore single line comments starting with ///< unfortunately cause a parsing error, as IntelliSense will assume the < is the start of an XML tag. This is not the case, but unfortunately, IntelliSense will still complain about the following space character rather than displaying the raw string. This commit alters all such comments to start with //!< instead, which prevents the issue.

Before:
Before Image

After:
After Image

This fixes issue #1622.

Single line comments starting with `///` are interpreted by
Microsoft Visual Studio as documentation containing XML code.

Therefore single line comments starting with `///<` unfortunately
cause a parsing error, as IntelliSense will assume the `<` is the
start of an XML tag. This is not the case, but unfortunately,
IntelliSense will still complain about the following space
character rather than displaying the raw string. This commit alters
all such comments to start with `//!<` instead, which prevents the
issue.

This fixes issue #1622.
@MarioLiebisch MarioLiebisch self-assigned this Nov 14, 2019
@eXpl0it3r eXpl0it3r added this to Discussion in SFML 2.6.0 via automation Nov 19, 2019
@eXpl0it3r eXpl0it3r added this to the 2.6 milestone Nov 19, 2019
Copy link
Member

@eXpl0it3r eXpl0it3r left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Will need to test how the generated documentation looks like, but otherwise it seems good.

@eXpl0it3r eXpl0it3r moved this from Discussion to Review & Testing in SFML 2.6.0 Nov 19, 2019
@MarioLiebisch
Copy link
Member Author

MarioLiebisch commented Nov 19, 2019

There's no difference. It's just alternative syntax to avoid issues such as this one. The generated files are 100% identical.

@eXpl0it3r
Copy link
Member

I know, question is more, did you check or are you just trusting that it is so? 😉

@MarioLiebisch
Copy link
Member Author

WinMerge said everything is identical. ;)

@eXpl0it3r eXpl0it3r moved this from Review & Testing to Ready in SFML 2.6.0 Nov 19, 2019
@eXpl0it3r eXpl0it3r merged commit a1d4bc8 into master Jan 2, 2020
SFML 2.6.0 automation moved this from Ready to Done Jan 2, 2020
@eXpl0it3r eXpl0it3r deleted the bugfix/doxygen-comment-format branch January 2, 2020 14:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
No open projects
SFML 2.6.0
  
Done
Development

Successfully merging this pull request may close these issues.

None yet

2 participants