Added XFlush call to WindowImplX11::setMouseCursor #1686
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eXpl0it3r
approved these changes
Jul 21, 2020
There was a problem hiding this comment.
Makes sense to me, but maybe @binary1248 has some additional remarks
binary1248
approved these changes
Jul 21, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changing the mouse cursor on Linux with SFML doesn't happen instantaneously.
When an application calls XDefineCursor directly shortly after having set the cursor via SFML (e.g. in order to use a system cursor that SFML doesn't support), then the calls will be executed in the wrong order. (If the same Display was used then they would be in the correct order, but the application can't access the display that SFML uses internally)
By calling XFlush after the call to XDefineCursor, the change is made immediately and external calls to XDefineCursor can no longer occur in the wrong order.
The XFlush call is already there in setMouseCursorVisible and other functions in WindowImplX11, it is just missing in setMouseCursor.