Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Github Actions. #1716

Merged
merged 1 commit into from Nov 20, 2020
Merged

Add Github Actions. #1716

merged 1 commit into from Nov 20, 2020

Conversation

elijahfhopp
Copy link
Contributor

  • Has this change been discussed on the forum or in an issue before? On the Discord server.
  • Does the code follow the SFML Code Style Guide? I think so, 馃槃
  • Have you provided some example/test code for your changes? It is CI, so you can checkout my fork.
  • If you have additional steps which need to be performed list them as tasks!

Description

This PR adds Github Actions to the SFML repo. It mirrors the Travis builds. Much formatting/cleanup help was provided by @kimci86. @JonnyPtn helped debug.

Tasks

  • Tested on Github
  • Maybe remove the Travis CI.

@eXpl0it3r eXpl0it3r added this to Discussion in SFML 2.6.0 via automation Nov 20, 2020
@eXpl0it3r eXpl0it3r moved this from Discussion to Ready in SFML 2.6.0 Nov 20, 2020
@eXpl0it3r eXpl0it3r added this to the 2.6 milestone Nov 20, 2020
eXpl0it3r
eXpl0it3r approved these changes Nov 20, 2020
View reviewed changes
Copy link
Member

@eXpl0it3r eXpl0it3r left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot for this!

Two improvements for separate PRs would be to execute the tests and then remove the travis builds

@eXpl0it3r eXpl0it3r merged commit c10c458 into SFML:master Nov 20, 2020
SFML 2.6.0 automation moved this from Ready to Done Nov 20, 2020
@eXpl0it3r eXpl0it3r mentioned this pull request Nov 29, 2020
Merged
@dogunbound dogunbound mentioned this pull request May 17, 2023
Merged
@ChrisThrasher ChrisThrasher mentioned this pull request Jun 23, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@eXpl0it3r eXpl0it3r eXpl0it3r approved these changes

Assignees
No one assigned
Labels
feature m:config
Projects
No open projects
SFML 2.6.0
  
Done
Milestone
2.6
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@elijahfhopp @eXpl0it3r