NetBSD support proposal.

[devnexen]

Thanks a lot for making a contribution to SFML! 🙂

Before you create the pull request, we ask you to check the follow boxes. (For small changes not everything needs to ticked, but the more the better!)

• Has this change been discussed on the forum or in an issue before?
• Does the code follow the SFML Code Style Guide?
• Have you provided some example/test code for your changes?
• If you have additional steps which need to be performed list them as tasks!

[eXpl0it3r]

I commented on some small stylistic changes.

As someone with no knowledge or experience with NetBSD, how would I go about testing this?

[Bromeon]

Is there any difference in behavior regarding the different BSD distributions?
If not, we might think about collapsing the config and #define constants.

[devnexen]

Mainly in term of joystick support in this case. Couple of os specifics too.

[Bromeon]

Basically, your PR is very similar to the existing FreeBSD joystick implementation, in small differences e.g. how to get joystick ID. Meanwhile, the OpenBSD implementation is an empty stub.

But in this case I'm not sure if it makes things more complicated to unify common code rather than duplicating it. The only thing I could imagine is if there is some Window/BSD folder with shared code -- not sure if it's worth it.

By the way, do you happen to know if the same code can be used on OpenBSD?

[devnexen]

By the way, do you happen to know if the same code can be used on OpenBSD?

It might ... maybe the only difference is the ioctl lookup id, just a glance in their code tree tough.

[eXpl0it3r]

I my opinion, code duplication is okay, if it's for the sake of isolating independent contexts/modules/etc.
Maybe there's a way to share more code between the different BSD versions, but I think that should then maybe be done as a separate PR.

[eXpl0it3r]

Thank you for the contribution! 🙂