[sprite] don't set default rect before the user provided one

[vfjpl]

Small Optimisation. Using second constructor with user provided rextureRect we first create the default one(by setTexture method) and then overwrite it with the user provided one. With this change we simply first set user provided textureRect and then set the texture which prevents unnecesary creating the default one.

Please review.

Cheers.

[eXpl0it3r]

Can you provide an example that explains the use case here?

Also have you seen the code in setTexture?

SFML/src/SFML/Graphics/Sprite.cpp

Lines 66 to 68 in 4cbb34d

	// Recompute the texture area if requested, or if there was no valid texture & rect before
	if (resetRect || (!m_texture && (m_textureRect == sf::IntRect())))
	setTextureRect(IntRect(0, 0, texture.getSize().x, texture.getSize().y));

[vfjpl]

Also have you seen the code in setTexture? yes, this is why I did this.

Exapmple is simple
sf::Sprite newSprite(texture, userRectangle);

Before sprite would create internal rectangle based on texture size, set texture, and then create new internal rectangle based on userRectangle.
Now it create new internal rectangle based on userRectangle and then sets the texture.

[eXpl0it3r]

Ah okay, that seems to make sense to me then. Somehow had a hard time understanding the purpose. 😄

@LaurentGomila any reason why we didn't do it this way from the beginning?

[LaurentGomila]

I don't really remember. Just a guess: the resetRect argument may have been added after the constructors, and we didn't really thought about this optimization.

[vfjpl]

@eXpl0it3r @LaurentGomila Potential problem seems to be when the user want to set rect to sf::IntRect(0, 0, 0, 0)
Like:
sf::Sprite newSprite(texture, sf::IntRect(0, 0, 0, 0));

before:
sprite would create internal rectangle based on texture size, set texture, and then create new internal rectangle based on userRectangle.
now:
sprite would create new internal rectangle based on userRectangle don't set any internal rectangle because it's already "0"

SFML/src/SFML/Graphics/Sprite.cpp

Line 78 in 4cbb34d

if (rectangle != m_textureRect)

, set texture and then create internal rectangle based on texture size (because rectangle the internal rectangle is all "0").

I'm not sure if there are any legitimate usages for setting rect to all 0 but it's something I didn't thought of yesterday.
Maybe it would be a bug in user code so we have "saved" him?

edit:
anyway if we wan't to allow user setting rect to sf::IntRect(0, 0, 0, 0) then simply changle line

SFML/src/SFML/Graphics/Sprite.cpp

Line 61 in 91fb6b6

setTexture(texture, false);

to m_texture = &texture;