Update CMake minimum version to 3.7.2 #1739
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Most package managers already support CMake 3.7.2 - Enables additional CMake features to be utilized
JonnyPtn
approved these changes
Jan 14, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The CMake version is currently constraint to 3.0.2 mostly because Debian Jessie only shipped with said version. Jessie has since been superseded by Stretch (2017-06-17), which itself has been superseded by Buster (2019-07-06).
According to Repology most distros do support CMake 3.7.2 or higher.
I chose 3.7.2 as it's the minimum version required for Android and it's the minimum version supported by Debian Buster.
This PR enables the implementation of other features, such as #1419
How to test this PR?
Build SFML on your platform of choice