Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Try more possible names for OpenGLES library. #1804

Merged
merged 1 commit into from Aug 9, 2021

Conversation

spacechase0
Copy link
Contributor

Description

This PR fixes issue #1687.

While googling around for alternatives, I found the other names here.

Let me know if my formatting is off, it's been I while since I've used C++ or SFML.

Tasks

  • Tested on iOS

How to test this PR?

According to the linked issue (and my own tests), all you need to do is run an app using the window module and make sure it doesn't crash with the error mentioned in #1687. I tested this on my iPhone 8 Plus, running iOS 14.4 (yes I need to update :P ).

img

Copy link
Member

@eXpl0it3r eXpl0it3r left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot for this change! Just had some small stylistic comments, if you want, I can also apply those for you.

src/SFML/Window/iOS/EaglContext.mm Outdated Show resolved Hide resolved
src/SFML/Window/iOS/EaglContext.mm Outdated Show resolved Hide resolved
@eXpl0it3r eXpl0it3r added this to Discussion in SFML 2.6.0 via automation Jun 29, 2021
@eXpl0it3r eXpl0it3r added this to the 2.6 milestone Jun 29, 2021
@eXpl0it3r eXpl0it3r moved this from Discussion to Review & Testing in SFML 2.6.0 Jun 29, 2021
Copy link
Member

@eXpl0it3r eXpl0it3r left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry, I totally forgot to re-review this again.

I've also taken the liberty to squash the two commits

SFML 2.6.0 automation moved this from Review & Testing to Ready Aug 9, 2021
@eXpl0it3r eXpl0it3r merged commit 47a4e88 into SFML:master Aug 9, 2021
SFML 2.6.0 automation moved this from Ready to Done Aug 9, 2021
@eXpl0it3r
Copy link
Member

Thanks a lot for the fix!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
No open projects
SFML 2.6.0
  
Done
Development

Successfully merging this pull request may close these issues.

None yet

2 participants