Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Only build Cocoa example when using Xcode #1949

Merged
merged 1 commit into from Jan 4, 2022

Conversation

ChrisThrasher
Copy link
Member

@ChrisThrasher ChrisThrasher commented Dec 31, 2021

Description

The Cocoa example program requires Xcode so I disabled this when using any other CMake generator on macOS.

Tasks

  • Tested on Linux
  • Tested on Windows
  • Tested on macOS
  • Tested on iOS
  • Tested on Android

How to test this PR?

Build SFML with SFML_BUILD_EXAMPLES=ON on macOS using Makefiles. Observe the following error:

xcode-select: error: tool 'ibtool' requires Xcode, but active developer directory '/Library/Developer/CommandLineTools' is a command line tools instance

@eXpl0it3r eXpl0it3r added this to Backlog in SFML 3.0.0 via automation Jan 2, 2022
@eXpl0it3r eXpl0it3r added this to the 3.0 milestone Jan 2, 2022
@eXpl0it3r eXpl0it3r moved this from Backlog to Clean Up Changes in SFML 3.0.0 Jan 2, 2022
@eXpl0it3r eXpl0it3r merged commit 7d47e74 into SFML:master Jan 4, 2022
SFML 3.0.0 automation moved this from Clean Up Changes to Done Jan 4, 2022
@ChrisThrasher ChrisThrasher deleted the cocoa-example-build branch January 5, 2022 01:33
@SFML SFML deleted a comment from vittorioromeo Dec 26, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Done
SFML 3.0.0
  
Done
Development

Successfully merging this pull request may close these issues.

None yet

3 participants