Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix -Wmissing-braces warning under clang (for SFML 2.6) #2048

Merged
merged 1 commit into from Mar 18, 2022
Merged

Fix -Wmissing-braces warning under clang (for SFML 2.6) #2048

merged 1 commit into from Mar 18, 2022

Conversation

nedoxff
Copy link

@nedoxff nedoxff commented Mar 16, 2022

Thanks a lot for making a contribution to SFML! 馃檪

Before you create the pull request, we ask you to check the follow boxes. (For small changes not everything needs to ticked, but the more the better!)

  • Has this change been discussed on the forum or in an issue before?
  • Does the code follow the SFML Code Style Guide?
  • Have you provided some example/test code for your changes?
  • If you have additional steps which need to be performed list them as tasks!

Description

Cherry-picked this commit because SFML 2.6 had the same problem with building with Clang..

This PR is related to the issue #2046 and PR #1914.

Tasks

This PR only effects Windows.

  • Tested on Linux
  • Tested on Windows
  • Tested on macOS
  • Tested on iOS
  • Tested on Android

How to test this PR?

Please check the original commit and the #2046 issue.

@eXpl0it3r eXpl0it3r added this to Discussion in SFML 2.6.0 via automation Mar 16, 2022
@eXpl0it3r eXpl0it3r added this to the 2.6 milestone Mar 16, 2022
@eXpl0it3r eXpl0it3r moved this from Discussion to Review & Testing in SFML 2.6.0 Mar 16, 2022
SFML 2.6.0 automation moved this from Review & Testing to Ready Mar 18, 2022
@eXpl0it3r eXpl0it3r merged commit 8838030 into SFML:2.6.x Mar 18, 2022
SFML 2.6.0 automation moved this from Ready to Done Mar 18, 2022
@eXpl0it3r
Copy link
Member

Thanks for this fix! 馃檪

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
No open projects
SFML 2.6.0
  
Done
Development

Successfully merging this pull request may close these issues.

None yet

4 participants