Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixes for Windows scancode implementation #2096

Merged
merged 5 commits into from Jun 13, 2022
Merged

Fixes for Windows scancode implementation #2096

merged 5 commits into from Jun 13, 2022

Conversation

kimci86
Copy link
Contributor

@kimci86 kimci86 commented May 8, 2022 •
edited

Description

This PR is related to the issue #1235.

  • It makes CI pass by locally disabling some warnings and finishing to rename Scancode values.
  • It provides some fixes for the scancode feature implementation on Windows:
    • delocalize(Key::Enter) is now Scan::Enter instead of Scan::NumpadEnter.
    • Better description for Scan::NumpadMinus and Scan::NumpadDivide.

I made many small commit to describe my changes but they can be squashed.

There are still remaining oddities that I couldn't manage to fix. See: #1235 (comment).

Tested using SFML-Input on Windows 10 with QWERTY (UK) and AZERTY (FR) keyboards.

@kimci86 kimci86 mentioned this pull request May 8, 2022
Closed
@eXpl0it3r eXpl0it3r added this to Discussion in SFML 2.6.0 via automation May 9, 2022
@eXpl0it3r eXpl0it3r added this to the 2.6 milestone May 9, 2022
@eXpl0it3r eXpl0it3r moved this from Discussion to WIP in SFML 2.6.0 May 9, 2022
@eXpl0it3r eXpl0it3r moved this from WIP to Review & Testing in SFML 2.6.0 May 9, 2022
SFML 2.6.0 automation moved this from Review & Testing to Ready Jun 13, 2022
@eXpl0it3r eXpl0it3r merged commit 0af5fcd into SFML:feature/scancode Jun 13, 2022
SFML 2.6.0 automation moved this from Ready to Done Jun 13, 2022
@eXpl0it3r
Copy link
Member

eXpl0it3r commented Jun 13, 2022 •
edited

Sorry for the long delay on merging these fixes. Might squash some of the commits on the main branch 🙂

@dogunbound dogunbound mentioned this pull request May 17, 2023
Merged
@ChrisThrasher ChrisThrasher mentioned this pull request Jun 23, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@eXpl0it3r eXpl0it3r eXpl0it3r approved these changes

Assignees
No one assigned
Labels
feature m:sfml-window
Projects
No open projects
SFML 2.6.0
  
Done
Milestone
2.6
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@kimci86 @eXpl0it3r